Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow descending values in abscissas and ordinates of Heatmap and LineVis #830

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Allow descending values in abscissas and ordinates of Heatmap and LineVis #830

merged 1 commit into from
Nov 2, 2021

Conversation

loichuder
Copy link
Member

@loichuder loichuder commented Oct 28, 2021 •
edited
Loading

Fix #822

@loichuder loichuder requested a review from axelboc October 28, 2021 08:12
axelboc
axelboc requested changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@axelboc axelboc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of suggestions.

apps/storybook/src/HeatmapVis.stories.tsx Outdated Show resolved Hide resolved
packages/lib/src/vis/utils.ts Outdated Show resolved Hide resolved
packages/lib/src/vis/heatmap/HeatmapVis.tsx Outdated Show resolved Hide resolved
@loichuder loichuder force-pushed the descending-values branch 3 times, most recently from d2bbd89 to 48efadb Compare November 2, 2021 08:26
axelboc
axelboc approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@axelboc axelboc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@loichuder loichuder merged commit c30e42b into main Nov 2, 2021
@loichuder loichuder deleted the descending-values branch November 2, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelboc axelboc axelboc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NeXus] Axes datasets with decreasing values break the tooltip
2 participants
@loichuder @axelboc