Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for NXentry or NXroot specifically when looking for NX groups #838

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Check for NXentry or NXroot specifically when looking for NX groups #838

merged 2 commits into from
Nov 3, 2021

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Nov 3, 2021

This ensures we don't show the NX badge next to non-plotable entities like NXcollection or NXinstrument. It also ensures that such NX entities are skipped when looking for a default NXdata group to plot.

@axelboc axelboc requested a review from loichuder November 3, 2021 13:02
loichuder
loichuder requested changes Nov 3, 2021
View reviewed changes
packages/app/src/vis-packs/nexus/utils.ts Outdated Show resolved Hide resolved
packages/shared/src/mock/metadata.ts Show resolved Hide resolved
@axelboc axelboc requested a review from loichuder November 3, 2021 14:19
@axelboc axelboc changed the title Check for NXentry specifically when looking for NX groups Check for NXentry or NXroot specifically when looking for NX groups Nov 3, 2021
@axelboc
Copy link
Contributor Author

axelboc commented Nov 3, 2021

/approve

@axelboc axelboc merged commit 741f1ec into main Nov 3, 2021
@axelboc axelboc deleted the fix branch November 3, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loichuder loichuder loichuder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axelboc @loichuder