Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports libhdf5 versions before v1.10.7 and 1.12.1 #113

Merged
merged 1 commit into from
May 15, 2023

Conversation

t20100
Copy link
Member

@t20100 t20100 commented May 15, 2023

This PR adds a check of the version of libhdf5 for support of the locking argument.

Alternatives could be not to support those versions and display a log message.

closes #106

@t20100 t20100 requested a review from loichuder May 15, 2023 11:57
@t20100 t20100 marked this pull request as draft May 15, 2023 12:14
Copy link
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jupyterlab_h5web/handlers.py Show resolved Hide resolved
@t20100 t20100 force-pushed the support-older-libhdf5 branch from 033c2bd to 2be7010 Compare May 15, 2023 12:23
@t20100
Copy link
Member Author

t20100 commented May 15, 2023

Tested with different versions of libhdf5.

@t20100 t20100 marked this pull request as ready for review May 15, 2023 12:26
@t20100 t20100 merged commit ca7ba19 into main May 15, 2023
@t20100 t20100 deleted the support-older-libhdf5 branch May 15, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 500
2 participants