Migrate to prebuilt extension to support JupyterLab v3.x #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loichuder
force-pushed
the
jlab3.1
branch
2 times, most recently
from
ec24c41 to
8d0c85b
Compare
|
Yes, if there is no way to support both at once, 2 branches sounds good (with a v1.x branch?)... and the sooner we can drop the older branch the simpler. |
loichuder
force-pushed
the
jlab3.1
branch
3 times, most recently
from
21fc93c to
53ea29e
Compare
loichuder
force-pushed
the
jlab3.1
branch
2 times, most recently
from
29a0980 to
13e9d92
Compare
4 tasks
loichuder
force-pushed
the
jlab3.1
branch
4 times, most recently
from
f8f8781 to
f16e1f4
Compare
loichuder
changed the title
|
If we break compatiblity with JLab 2, we might as well cross the bridge entirely and migrate to a prebuilt extension. Therefore:
|
loichuder
commented
Nov 4, 2021
t20100
reviewed
Nov 4, 2021
| @@ -110,6 +89,9 @@ See https://github.com/silx-kit/jupyterlab-h5web/releases. | |||
|
|
|||
| ## Troubleshoot | |||
|
|
|||
| If the following instructions do not solve your issue, you can open an | |||
| [issue on GitHub](https://github.com/silx-kit/jupyterlab-h5web/issues). | |||
There was a problem hiding this comment.
You could also point to h5web@esrf.fr for people without a github account
t20100
reviewed
Nov 4, 2021
t20100
reviewed
Nov 4, 2021
t20100
approved these changes
Nov 4, 2021
Co-authored-by: Max Klein <telamonian@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #49
Unfortunately, this breaks compatibility with JupyterLab 2.x. We might need to work on separate branches/releases.