Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace event interception with patch of docManager.open #65

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

loichuder
Copy link
Member

@loichuder loichuder commented Nov 5, 2021

Fix #61

TS is not happy

@loichuder loichuder changed the title Replace event interception with patch of listing.handleOpen Draft: Replace event interception with patch of listing.handleOpen Nov 5, 2021
@loichuder loichuder force-pushed the patch-patch branch 3 times, most recently from a536159 to 8f4211a Compare November 5, 2021 15:03
@loichuder loichuder requested a review from axelboc November 5, 2021 15:05
@loichuder loichuder changed the title Draft: Replace event interception with patch of listing.handleOpen Replace event interception with patch of docManager.open Nov 5, 2021
src/browser.ts Outdated Show resolved Hide resolved
@loichuder loichuder merged commit 28a70e9 into main Nov 5, 2021
@loichuder loichuder deleted the patch-patch branch November 5, 2021 15:49
@loichuder loichuder added the backport 0.x Pull request to be backported to 0.x label Nov 5, 2021
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

The backport to 0.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-0.x 0.x
# Navigate to the new working tree
cd .worktrees/backport-0.x
# Create a new branch
git switch --create backport-65-to-0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick b16c7fa13085b92d276bc5ba46a42296cc96ed0c
# Push it to GitHub
git push --set-upstream origin backport-65-to-0.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-0.x

Then, create a pull request where the base branch is 0.x and the compare/head branch is backport-65-to-0.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 0.x Pull request to be backported to 0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enter key presses are intercepted for all filebrowser operations (e.g. renaming and deleting)
2 participants