Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silx.gui.plot.ImageStack: fix _urlIndexes initialization. #4189

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

payno
Copy link
Member

@payno payno commented Oct 31, 2024

Make sure ImageStack._urlIndexes is always a dict.

This can be lead to errors when calling ImageStack.getUrls before any url is called and better for consistency.

@payno payno self-assigned this Oct 31, 2024
@payno payno requested a review from t20100 October 31, 2024 12:29
@payno payno added the bug label Oct 31, 2024
@payno payno force-pushed the fix_image_stack_API branch from 5dcd076 to da3a74f Compare October 31, 2024 12:30
Copy link
Member

@t20100 t20100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails for other reasons (some deprecation warnings) that can be fixed in another PR.

@payno payno merged commit 95eeb53 into main Nov 4, 2024
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants