Enable support for exporting 1D and 2D dataset slices. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
force-pushed
the
main
branch
2 times, most recently
from
70c2d7e to
47bdbd7
Compare
|
I've refactored the CSV export logic a bit to avoid filtering out dimensions with cardinality of 1 and to avoid having a specific Thanks again @mandrew9! |
axelboc
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20
I'm admittedly not an expert with TypeScript or VS Code extensions, but I think this implementation for exporting data slices within the VS Code extension follows your guidelines provided in the associated ticket. Please let me know if there's anything I can do to improve the implementation.