-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker improvements #474
Docker improvements #474
Conversation
…n favor of automatically generated files
Might be worth making it pass hadolint while we're at it? |
@@ -13,10 +13,23 @@ WORKDIR "/src" | |||
# Build release | |||
RUN dotnet publish -p:Version=$VERSION -c Release --self-contained true -p:PublishSingleFile=true -o out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if we suppressed warnings during the GHAs since at that point they just balloon the logs. I want to take a crack at clearing them up in the future, but by the time the GHAs run, the tag is already cut, so it's already too late to fix them for that release. I'll set up at an action that triggers on PRs in the future once we get the current crop handled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the best way to do this. As far as I can tell, the warnings are created by MSBuild. The dotnet publish command supports setting the verbosity (https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-publish). We could set that to silent. It's hard to tell locally, but I don't think that affects the MSBuild output though.
Sounds good. I can post an update with both of those changes later. Looks like hadolint only wants |
This PR makes 3 changes
auth.json
andconfig.json
files similar to the windows build process instead of using the previously hard-coded values