Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(phpunit): remove beStrictAboutTodoAnnotatedTests #177

Merged
merged 1 commit into from
Aug 11, 2024
+0 −1
Merged

ci(phpunit): remove beStrictAboutTodoAnnotatedTests #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion phpunit.xml.dist
View file
Original file line number Diff line number Diff line change
@@ -4,7 +4,6 @@
xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
beStrictAboutChangesToGlobalState="true"
beStrictAboutOutputDuringTests="true"
beStrictAboutTodoAnnotatedTests="true"
executionOrder="random"
colors="true"
bootstrap="tests/bootstrap.php"

Unchanged files with check annotations Beta

View file
src/Clients/Consumer/KafkaConsumer.php
public function __construct(ConsumerConfig $config, LoggerInterface|null $logger = null)
{
$this->logger = $logger ?? new NullLogger();

Check warning on line 36 in src/Clients/Consumer/KafkaConsumer.php

GitHub Actions / Infection 

Escaped Mutant for Mutator "Coalesce":

@@ @@
     private bool $shouldRun = true;
     public function __construct(ConsumerConfig $config, LoggerInterface|null $logger = null)
     {
-        $this->logger = $logger ?? new NullLogger();
+        $this->logger = new NullLogger() ?? $logger;
         $this->setupInternalTerminationSignal($config);
         $config->getConf()->setErrorCb(function (RdKafkaConsumer $kafka, int $err, string $reason): void {
             $this->logger->error(sprintf('Kafka error: "%s": "%s"', rd_kafka_err2str($err), $reason), ['err' => $err]);
$this->setupInternalTerminationSignal($config);

Check warning on line 38 in src/Clients/Consumer/KafkaConsumer.php

GitHub Actions / Infection 

Escaped Mutant for Mutator "MethodCallRemoval":

@@ @@
     public function __construct(ConsumerConfig $config, LoggerInterface|null $logger = null)
     {
         $this->logger = $logger ?? new NullLogger();
-        $this->setupInternalTerminationSignal($config);
+        
         $config->getConf()->setErrorCb(function (RdKafkaConsumer $kafka, int $err, string $reason): void {
             $this->logger->error(sprintf('Kafka error: "%s": "%s"', rd_kafka_err2str($err), $reason), ['err' => $err]);
         });
$config->getConf()->setErrorCb(

Check warning on line 40 in src/Clients/Consumer/KafkaConsumer.php

GitHub Actions / Infection 

Escaped Mutant for Mutator "MethodCallRemoval":

@@ @@
     {
         $this->logger = $logger ?? new NullLogger();
         $this->setupInternalTerminationSignal($config);
-        $config->getConf()->setErrorCb(function (RdKafkaConsumer $kafka, int $err, string $reason): void {
-            $this->logger->error(sprintf('Kafka error: "%s": "%s"', rd_kafka_err2str($err), $reason), ['err' => $err]);
-        });
+        
         $rebalanceCallback = function (RdKafkaConsumer $kafka, int $err, array|null $partitions = null): void {
             switch ($err) {
                 case RD_KAFKA_RESP_ERR__ASSIGN_PARTITIONS:
function (RdKafkaConsumer $kafka, int $err, string $reason): void {
$this->logger->error(
sprintf('Kafka error: "%s": "%s"', rd_kafka_err2str($err), $reason),
function (RdKafkaConsumer $kafka, int $err, array|null $partitions = null): void {
switch ($err) {
case RD_KAFKA_RESP_ERR__ASSIGN_PARTITIONS:
$this->logger->debug(

Check warning on line 54 in src/Clients/Consumer/KafkaConsumer.php

GitHub Actions / Infection 

Escaped Mutant for Mutator "MethodCallRemoval":

@@ @@
         $rebalanceCallback = function (RdKafkaConsumer $kafka, int $err, array|null $partitions = null): void {
             switch ($err) {
                 case RD_KAFKA_RESP_ERR__ASSIGN_PARTITIONS:
-                    $this->logger->debug('Assigning partitions', $partitions === null ? [] : array_map(static function (TopicPartition $partition): string {
-                        return (string) $partition->getPartition();
-                    }, $partitions));
+                    
                     $kafka->assign($partitions);
                     break;
                 case RD_KAFKA_RESP_ERR__REVOKE_PARTITIONS:
'Assigning partitions',
$partitions === null ? [] : array_map(

Check warning on line 56 in src/Clients/Consumer/KafkaConsumer.php

GitHub Actions / Infection 

Escaped Mutant for Mutator "Identical":

@@ @@
         $rebalanceCallback = function (RdKafkaConsumer $kafka, int $err, array|null $partitions = null): void {
             switch ($err) {
                 case RD_KAFKA_RESP_ERR__ASSIGN_PARTITIONS:
-                    $this->logger->debug('Assigning partitions', $partitions === null ? [] : array_map(static function (TopicPartition $partition): string {
+                    $this->logger->debug('Assigning partitions', $partitions !== null ? [] : array_map(static function (TopicPartition $partition): string {
                         return (string) $partition->getPartition();
                     }, $partitions));
                     $kafka->assign($partitions);

Check warning on line 56 in src/Clients/Consumer/KafkaConsumer.php

GitHub Actions / Infection 

Escaped Mutant for Mutator "UnwrapArrayMap":

@@ @@
         $rebalanceCallback = function (RdKafkaConsumer $kafka, int $err, array|null $partitions = null): void {
             switch ($err) {
                 case RD_KAFKA_RESP_ERR__ASSIGN_PARTITIONS:
-                    $this->logger->debug('Assigning partitions', $partitions === null ? [] : array_map(static function (TopicPartition $partition): string {
-                        return (string) $partition->getPartition();
-                    }, $partitions));
+                    $this->logger->debug('Assigning partitions', $partitions === null ? [] : $partitions);
                     $kafka->assign($partitions);
                     break;
                 case RD_KAFKA_RESP_ERR__REVOKE_PARTITIONS:

Check warning on line 56 in src/Clients/Consumer/KafkaConsumer.php

GitHub Actions / Infection 

Escaped Mutant for Mutator "Ternary":

@@ @@
         $rebalanceCallback = function (RdKafkaConsumer $kafka, int $err, array|null $partitions = null): void {
             switch ($err) {
                 case RD_KAFKA_RESP_ERR__ASSIGN_PARTITIONS:
-                    $this->logger->debug('Assigning partitions', $partitions === null ? [] : array_map(static function (TopicPartition $partition): string {
+                    $this->logger->debug('Assigning partitions', $partitions === null ? array_map(static function (TopicPartition $partition): string {
                         return (string) $partition->getPartition();
-                    }, $partitions));
+                    }, $partitions) : []);
                     $kafka->assign($partitions);
                     break;
                 case RD_KAFKA_RESP_ERR__REVOKE_PARTITIONS:
static function (TopicPartition $partition): string {
return (string) $partition->getPartition();
},
$kafka->assign();
}
};
$config->getConf()->setRebalanceCb($rebalanceCallback);

Check warning on line 82 in src/Clients/Consumer/KafkaConsumer.php

GitHub Actions / Infection 

Escaped Mutant for Mutator "MethodCallRemoval":

@@ @@
                     $kafka->assign();
             }
         };
-        $config->getConf()->setRebalanceCb($rebalanceCallback);
+        
         parent::__construct($config->getConf());
     }
     /**
parent::__construct($config->getConf());
}
$consumerRecords,
): void {
$consumerRecords->add($message);
if ($processRecord !== null) {

Check warning on line 125 in src/Clients/Consumer/KafkaConsumer.php

GitHub Actions / Infection 

Escaped Mutant for Mutator "NotIdentical":

@@ @@
         $consumerRecords = new ConsumerRecords();
         $this->doStart($timeoutMs, function (Message $message) use ($maxBatchSize, $timeoutMs, $batchTime, $processRecord, $onBatchProcessed, $consumerRecords): void {
             $consumerRecords->add($message);
-            if ($processRecord !== null) {
+            if ($processRecord === null) {
                 $processRecord($message);
             }
             if ($consumerRecords->count() === $maxBatchSize) {
$processRecord($message);

Check warning on line 126 in src/Clients/Consumer/KafkaConsumer.php

GitHub Actions / Infection 

Escaped Mutant for Mutator "FunctionCallRemoval":

@@ @@
         $this->doStart($timeoutMs, function (Message $message) use ($maxBatchSize, $timeoutMs, $batchTime, $processRecord, $onBatchProcessed, $consumerRecords): void {
             $consumerRecords->add($message);
             if ($processRecord !== null) {
-                $processRecord($message);
+                
             }
             if ($consumerRecords->count() === $maxBatchSize) {
                 if ($onBatchProcessed !== null && !$consumerRecords->isEmpty()) {
}
if ($consumerRecords->count() === $maxBatchSize) {