Conformance to UISegmentedControl #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make SMBasicSegmentView to inherit from UIControl, it makes it conformant to standard controls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
Changed base class of
SMBasicSegmentViewtoUIControland added action sending forValueChanged- the same as in UISegmentedControl.Also added
selectedSegmentIndexproperty (same as in UISegmentedControl) while deprecatingindexOfSelectedSegment. Both works properly so there are no breaking changes, but at some time you could delete the deprecated property.I assumed the next version will be
1.2.0so I used it in the@availableannotation, but you could of course change it to your needs. If you would like to I can add another commit with changedInfo.plistand.podspecfor1.2.0version.