Merge pull request #55 from jhndrx/dehumidifier-fixes

Dehumidifier Current Humidity Value Fix
simbaja · Jul 30, 2023 · 0362251 · 0362251
2 parents f3e90ea + 61a4606
commit 0362251
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/gehomesdk/__init__.py b/gehomesdk/__init__.py
@@ -1,6 +1,6 @@
 """GE Home SDK"""
 
-__version__ = "0.5.13"
+__version__ = "0.5.14"
 
 
 from .clients import *

diff --git a/gehomesdk/erd/converters/dehumidifier/__init__.py b/gehomesdk/erd/converters/dehumidifier/__init__.py
@@ -1 +1,2 @@
-from .erd_dehumidifier_maintenance_converter import ErdDehumidifierMaintenanceConverter
+from .erd_dehumidifier_maintenance_converter import ErdDehumidifierMaintenanceConverter
+from .erd_dehumidifier_current_humidity_converter import ErdDehumidifierCurrentHumidityConverter
diff --git a/gehomesdk/erd/converters/dehumidifier/erd_dehumidifier_current_humidity_converter.py b/gehomesdk/erd/converters/dehumidifier/erd_dehumidifier_current_humidity_converter.py
@@ -0,0 +1,10 @@
+from ..abstract import ErdReadWriteConverter
+from ..primitives import *
+
+
+class ErdDehumidifierCurrentHumidityConverter(ErdReadWriteConverter[int]):
+    def erd_decode(self, value: str) -> int:
+        try:
+            return erd_decode_int(value) & 0xFF
+        except:
+            return 0
diff --git a/gehomesdk/erd/erd_configuration.py b/gehomesdk/erd/erd_configuration.py
@@ -265,7 +265,7 @@ def erd_encode(self, value: Any) -> str:
 
     #Dehumidifier
     ErdConfigurationEntry(ErdCode.DHUM_TARGET_HUMIDITY, ErdIntConverter(), ErdCodeClass.DEHUMIDIFIER_SENSOR, ErdDataType.INT),
-    ErdConfigurationEntry(ErdCode.DHUM_CURRENT_HUMIDITY, ErdReadOnlyIntConverter(), ErdCodeClass.DEHUMIDIFIER_SENSOR, ErdDataType.INT),
+    ErdConfigurationEntry(ErdCode.DHUM_CURRENT_HUMIDITY, ErdDehumidifierCurrentHumidityConverter(), ErdCodeClass.DEHUMIDIFIER_SENSOR, ErdDataType.INT),
     ErdConfigurationEntry(ErdCode.DHUM_MAINTENANCE, ErdDehumidifierMaintenanceConverter(), ErdCodeClass.DEHUMIDIFIER_SENSOR),
 
     #Hood