Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major reorg #32

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Major reorg #32

merged 1 commit into from
Jul 16, 2024

Conversation

lemire
Copy link
Member

@lemire lemire commented Jul 16, 2024

Eventually, we want to merge this code into simdjson, and this PR is a step in this direction. Furthermore, we want to make it easier for newcomers to contribute so we want to just outline the proper code and leave what is less essential to the side, where only interested reader might go.

This PR keeps only the essential files in include/simdjson/json_builder. The namespaces are changed. We also fallback on the simdjson convention where header files end with .h. I am aware that in C++, some people prefer .hpp, but that's not the current convention in simdjson. Elsewhere, .hpp headers are changed.

The PR moves the parser to the benchmarking directory. Much is moved there. For example, the dependencies are moved there so that if you want to just build the tests or the examples, you do not need to build the dependencies.

The CMake setup is now more standard in the sense that there is one project, and there are subdirectories.

The PR removes the small JSON parser from the examples and uses simdjson instead. This was done manually, but should be done automagically as per #29

The universal_formatter is kept in include/simdjson/json_builder but remains unused. We need to test it out (see #6). If anyone wants to play with that, it would be great.

cc @CarlosEduR

Copy link
Member

@FranciscoThiesen FranciscoThiesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to reorganize it. I am excited to be part of adding this to simdjson (:

@FranciscoThiesen FranciscoThiesen merged commit 9b0219d into main Jul 16, 2024
@CarlosEduR
Copy link
Member

Nice work @lemire!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants