Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually, we want to merge this code into simdjson, and this PR is a step in this direction. Furthermore, we want to make it easier for newcomers to contribute so we want to just outline the proper code and leave what is less essential to the side, where only interested reader might go.
This PR keeps only the essential files in
include/simdjson/json_builder
. The namespaces are changed. We also fallback on the simdjson convention where header files end with.h
. I am aware that in C++, some people prefer.hpp
, but that's not the current convention in simdjson. Elsewhere,.hpp
headers are changed.The PR moves the parser to the benchmarking directory. Much is moved there. For example, the dependencies are moved there so that if you want to just build the tests or the examples, you do not need to build the dependencies.
The CMake setup is now more standard in the sense that there is one project, and there are subdirectories.
The PR removes the small JSON parser from the examples and uses simdjson instead. This was done manually, but should be done automagically as per #29
The
universal_formatter
is kept ininclude/simdjson/json_builder
but remains unused. We need to test it out (see #6). If anyone wants to play with that, it would be great.cc @CarlosEduR