Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doc links examples & recipes #139

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

paulgrotzke
Copy link

fixes #118

hey,
this will fix these behaviours

Examples:
All 'Recipe' style links on the Examples page are broken, resulting in a 404.

Recipes:
All 'Recipe' style links on the Recipes page are broken, resulting in a 404.
The 'Recipe' style links have broken images.

This behaviour could i not reproduce

Sidebar:
Pips link within Options does not navigate to the pips prop in the article.
Range link within Options does not navigate to the range prop in the article.

Links LGTM:
https://simeydotme.github.io/svelte-range-slider-pips/en/options/#pips
https://simeydotme.github.io/svelte-range-slider-pips/en/options/#range

i guess the problem why the current behaviour works on dev server is how the astro dev server is handling the case that the example.mdx links to a file inside example/**.mdx

@simeydotme
Copy link
Owner

thanks @paulgrotzke ... i'll just merge this since i havent had enough time to figure it out, or move to the new astro version 🙇

@simeydotme simeydotme merged commit 0bc34f9 into simeydotme:astro-pages Mar 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants