Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segfault in optimized ssss #7

Closed
bennybp opened this issue Apr 30, 2018 · 0 comments · Fixed by #10
Closed

Segfault in optimized ssss #7

bennybp opened this issue Apr 30, 2018 · 0 comments · Fixed by #10

Comments

@bennybp
Copy link
Contributor

bennybp commented Apr 30, 2018

There is a segfault in the hand-optimized version of ostei_s_s_s_s.c

simint-generator/skel/ostei_s_s_s_s.c

Line 199 in 800c6e3

SIMINT_DBLTYPE prim_screen_res = SIMINT_MUL(bra_screen_max, SIMINT_DBLLOAD(Q.screen, j));

If screening has not been performed when creating the shell pair, Q.screen will be a null pointer. This should be moved into the check_screen conditional, and the block with SIMINT_PRIM_SCREEN_STAT changed.
edoapra referenced this issue in edoapra/simint-generator Jul 3, 2018
@echow
Merge pull request #7 from huanghua1994/master
a589883 
Change batching interface and optimize for ostei_general_vrr_I()
edoapra added a commit to edoapra/simint-generator that referenced this issue Jul 3, 2018
@edoapra
Fix for segv when no screening is used. Could fix simint-chem#7. More…
b7366cd 
… testing is needed
@edoapra edoapra mentioned this issue Jul 5, 2018
Merged
@echow echow closed this as completed in #10 Jul 28, 2018
echow pushed a commit that referenced this issue Apr 6, 2022
@edoapra
Merge pull request #7 from dmejiar/master
3d7d4bf 
Fix FPEs when using fastschwarz screening
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for segv when no integral primitive screening is used. edoapra/simint-generator
1 participant
@bennybp