Default to prepare_v2 if prepare_v3 not found #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simolus3
added a commit
that referenced
this pull request
Jul 14, 2020
|
Thanks for the PR! Unfortunately the |
|
Ah ok sorry for missing that. I guess I just throw something to see that this was indeed the only remaining issue (as I could not test it locally). Great indeed that you test on ubuntu 16.04. Thanks! Looking forward for a new published version! |
|
Just published version |
|
Hooray! : https://travis-ci.org/github/tekartik/sqflite/builds/708061710 I published sqflite_common_ffi 1.1.0 based on your lib. Thanks again for your work. Bravo! |
Closed
Closed
Closed
davidmartos96
pushed a commit
to davidmartos96/sqlite3.dart
that referenced
this pull request
Oct 9, 2024
…ust-extension-wasm PowerSync core rust extension wasm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it seems that travis is still stuck on Ubuntu 16.04 causing the library to fail (hence all the sqflite tests - I added an issue here https://travis-ci.community/t/change-ubuntu-distribution-from-16-04/9320 but I'm not sure when/if it will get fixed).
Here I propose to try to load prepare_v3 and load prepare_v2 if not found.
I also added travis tests (see the build history https://travis-ci.org/github/tekartikdev/sqlite3.dart/builds to see that it was failing before - I made 2 attemps to fix the issue). You might want to change the implementation.
Thanks!