Support Dir.glob with Pathname. #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm I don't think Travis is supporting Ruby older than 2.0.0 any more. It fails wit this message:
|
This works with stdlib:
require 'pathname'
p = Pathname.new('/')
Dir[p]
# => ["/"]
But before this change failed under MemFs:
TypeError:
no implicit conversion of Pathname into String
This is more likely to be encountered in a Rails project where
`Rails.root` is a `Pathname`, but it's very possible to encounter this
in an Ruby project.
| @@ -216,6 +217,9 @@ module MemFs | |||
| it_behaves_like 'returning matching filenames', '/test?', %w[/test0 /test1 /test2] | |||
| it_behaves_like 'returning matching filenames', '/test[01]', %w[/test0 /test1] | |||
| it_behaves_like 'returning matching filenames', '/test[^2]', %w[/test0 /test1] | |||
| it_behaves_like 'returning matching filenames', Pathname.new('/'), %w[/] | |||
| it_behaves_like 'returning matching filenames', Pathname.new('/*'), | |||
| %w[/tmp /test0 /test1 /test2] | |||
There was a problem hiding this comment.
Align the parameters of a method call if they span more than one line.
|
Hi @craigw. Thank you very much for your PR that's so cool! 😁 |
simonc
pushed a commit
that referenced
this pull request
Jun 5, 2016
This works with stdlib:
require 'pathname'
p = Pathname.new('/')
Dir[p]
# => ["/"]
But before this change failed under MemFs:
TypeError:
no implicit conversion of Pathname into String
This is more likely to be encountered in a Rails project where
`Rails.root` is a `Pathname`, but it's very possible to encounter this
in an Ruby project.
Closes #21.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works with stdlib:
But before this change failed under MemFs:
This is more likely to be encountered in a Rails project where
Rails.rootis aPathname, but it's very possible to encounter thisin an Ruby project.