Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kitty support to shape #6

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Conversation

ctrlcctrlv
Copy link
Contributor

@ctrlcctrlv ctrlcctrlv commented Aug 4, 2020

Close #5

image

@simoncozens
Copy link
Owner

I'd prefer to keep this as one utility, to make distribution and installation easier; especially since most users will only use one. And there's a lot of repeated code. Why not do a $ENV test in Perl?

@ctrlcctrlv
Copy link
Contributor Author

OK; force-pushed. The reason I didn't do it in Perl is so I could avoid having to Google "if-else in Perl", "environment variables in Perl", "string length in Perl", &c. Clearly, you're not amused by my lack of Perl knowledge, so now I'm at least a Perl n00b.

:-)

By the way, a cool kitty feature is that this works in vim's command buffer:

image

@ctrlcctrlv
Copy link
Contributor Author

🦗

@simoncozens simoncozens merged commit 10970ef into simoncozens:master Sep 1, 2020
@simoncozens
Copy link
Owner

Sorry about the delay - looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Kitty image protocol support
2 participants