feat: Allow using the cache when triggering requests manually #20
Conversation
| } | ||
|
|
||
| interface Options { | ||
| manual: boolean | ||
| } | ||
|
|
||
| interface RefetchOptions { | ||
| useCache: boolean |
There was a problem hiding this comment.
As discussed in the Issue, I think it would be better to allow a user to choose to use caching for the standard useAxios behaviour or refetch. If that was decision was made, useCache could move to the Options interface. As it stands though, having useCache in this new RefetchOptions interface works.
There was a problem hiding this comment.
I'm not convinced we should have that option there to be honest. I mean the hook will execute whenever the component renders, meaning that having that option there and choosing to not use the cache will trigger a request whenever the component re-renders, which I see no reason why anybody would want to do. I think we should stick to the option being provided to the "refetch" function, with cache off by default, as in this PR.
There was a problem hiding this comment.
"I see no reason why anybody would want to do" - I guess it depends how volatile the data is on the server. TBH I am happy with what you have proposed so I reckon you should go ahead and merge the PR.
There was a problem hiding this comment.
Not really, because you shouldn't rely on the frequency with which a component renders to carry out any application logic. That should be transparent for the developer.
There was a problem hiding this comment.
Ok, fair enough. It's just that cache invalidation is always a nightmare! Good work @simoneb
There was a problem hiding this comment.
I know. If you've used Apollo you know that it's really not easy to implement and use.
|
Released in 1.2.0 |
Closes #19