Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert FastBook workarounds in cdn providers #771

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Revert FastBook workarounds in cdn providers #771

merged 4 commits into from
Nov 19, 2024

Conversation

simonihmig
Copy link
Owner

Instead of working around a known issue in the actual runtime code, users need to add a FastBoot config to expose needed globals like URL or URLSearchParams, as documented in the Ember guide.

Copy link

changeset-bot bot commented Nov 19, 2024

🦋 Changeset detected

Latest commit: b5dacfe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@responsive-image/ember Major
@responsive-image/cdn Patch
wc-lit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for responsive-image-docs ready!

Name Link
🔨 Latest commit b5dacfe
🔍 Latest deploy log https://app.netlify.com/sites/responsive-image-docs/deploys/673d02219edd3c0008f17bd4
😎 Deploy Preview https://deploy-preview-771--responsive-image-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@simonihmig simonihmig merged commit f5c7dbc into main Nov 19, 2024
16 checks passed
@simonihmig simonihmig deleted the fastboot-fix branch November 19, 2024 22:23
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant