Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hledger-web --file-url has no effect #2139

Closed
simonmichael opened this issue Dec 15, 2023 · 3 comments
Closed

hledger-web --file-url has no effect #2139

simonmichael opened this issue Dec 15, 2023 · 3 comments
Labels
A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. cli Command line parsing, options, arguments and suchlike. docs Documentation-related. web The hledger-web tool.

Comments

@simonmichael
Copy link
Owner

--file-url (renamed from --static-root in 0.23) hasn't worked as far back as I have tested (hledger-web-1.0). I'll just drop it, unless someone wants to debug.
@simonmichael simonmichael added A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. web The hledger-web tool. labels Dec 15, 2023
@simonmichael
Copy link
Owner Author

(Perhaps it worked when built with older yesod versions ?)

@simonmichael simonmichael added the cli Command line parsing, options, arguments and suchlike. label Dec 15, 2023
@simonmichael
Copy link
Owner Author

Or would you care to take a look @xiaoruoruo ? I see you contributed --static-root in #150.

Possibly related:

simonmichael added a commit that referenced this issue Dec 15, 2023
@simonmichael
dev:web: add tests: --base-url, --file-url (disabled) [#2127, #2139]
5601d64
simonmichael added a commit that referenced this issue Dec 15, 2023
@simonmichael
dev:web: add tests: --base-url, --file-url (disabled) [#2127], [#2139]
d5b9678
simonmichael added a commit that referenced this issue Dec 15, 2023
@simonmichael
fix:web: drop non-working --file-url option for now [#2139]
60f7896
@simonmichael simonmichael added the docs Documentation-related. label Dec 16, 2023
@simonmichael
Copy link
Owner Author

Closed by removal, can be reopened when needed.

simonmichael added a commit that referenced this issue Jan 1, 2024
@simonmichael
dev:web: add tests: --base-url, --file-url (disabled) [#2127], [#2139]
4c6827a
simonmichael added a commit that referenced this issue Jan 1, 2024
@simonmichael
fix:web: drop non-working --file-url option for now [#2139]
80cc27f
@Porkepix Porkepix mentioned this issue Jan 1, 2024
Merged
@totorowechat totorowechat mentioned this issue Jan 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. cli Command line parsing, options, arguments and suchlike. docs Documentation-related. web The hledger-web tool.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonmichael