Skip to content

Commit

Permalink
[Mono] Skip flaky android tests (dotnet#61460)
Browse files Browse the repository at this point in the history
There are connectivity issues on some physical Android devices. We should disable the affected tests until the issue isn't resolved.

Ref dotnet#61343
  • Loading branch information
simonrozsival authored Nov 11, 2021
1 parent a761b9f commit 8ad84e8
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ public class UnixPingUtilityTests
[InlineData(1000)]
[InlineData(1500)]
[PlatformSpecific(TestPlatforms.AnyUnix)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)]
public static void TimeoutIsRespected(int timeout)
{
Process p = ConstructPingProcess(IPAddress.Parse(TestSettings.UnreachableAddress), 50, timeout);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ public async Task NullEndpoint_Throws_ArgumentException()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)]
public async Task Datagram_UDP_ShouldImplicitlyBindLocalEndpoint()
{
using var socket = new Socket(AddressFamily.InterNetwork, SocketType.Dgram, ProtocolType.Udp);
Expand All @@ -84,6 +85,7 @@ public async Task Datagram_UDP_ShouldImplicitlyBindLocalEndpoint()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)]
public async Task Datagram_UDP_AccessDenied_Throws_DoesNotBind()
{
IPEndPoint invalidEndpoint = new IPEndPoint(IPAddress.Broadcast, 1234);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ public void ReuseUnicastPort_CreateSocketSetOption()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)]
public void MulticastOption_CreateSocketSetGetOption_GroupAndInterfaceIndex_SetSucceeds_GetThrows()
{
int interfaceIndex = 0;
Expand All @@ -65,6 +66,7 @@ public void MulticastOption_CreateSocketSetGetOption_GroupAndInterfaceIndex_SetS
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoNorServerCore))] // Skip on Nano: https://github.com/dotnet/runtime/issues/26286
[ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)]
public async Task MulticastInterface_Set_AnyInterface_Succeeds()
{
// On all platforms, index 0 means "any interface"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,7 @@ public void Connect_InvalidArguments_Throws()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)]
public async Task ConnectAsync_StringHost_Success()
{
using (var c = new UdpClient())
Expand All @@ -448,6 +449,7 @@ public async Task ConnectAsync_StringHost_Success()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)]
public async Task ConnectAsync_IPAddressHost_Success()
{
using (var c = new UdpClient())
Expand All @@ -457,6 +459,7 @@ public async Task ConnectAsync_IPAddressHost_Success()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)]
public void Connect_StringHost_Success()
{
using (var c = new UdpClient())
Expand All @@ -466,6 +469,7 @@ public void Connect_StringHost_Success()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)]
public void Connect_IPAddressHost_Success()
{
using (var c = new UdpClient())
Expand Down

0 comments on commit 8ad84e8

Please sign in to comment.