simonrw · simonrw · Jun 18, 2018 · Jul 17, 2018 · Jul 17, 2018 · melissachang
diff --git a/Pipfile b/Pipfile
@@ -0,0 +1,12 @@
+[[source]]
+url = "https://pypi.org/simple"
+verify_ssl = true
+name = "pypi"
+
+[packages]
+yapf = "*"
+
+[dev-packages]
+
+[requires]
+python_version = "3.6"
diff --git a/Pipfile.lock b/Pipfile.lock
diff --git a/README.rst b/README.rst
@@ -123,3 +123,5 @@ Alternatively alternatively yapf could be set as the ``equalprg``:
 and reformat the whole file with ``gg=G`` or a single line with ``=``.
 
 .. _gq{motion}: https://github.com/vim/vim/blob/b182b40080a23ea1e1ffa28ea03b412174a236bb/runtime/doc/change.txt#L1299
+
+Note: if ``vim-yapf`` is used in this way, any errors will overwrite the current buffer. Make sure to check the buffer for errors before saving. Regardless, the ``undo`` command should work.
diff --git a/t/basics.vim b/t/basics.vim
@@ -10,4 +10,10 @@ describe 'Yapf'
         call Yapf()
         Expect getline(8) == "class foo(object):"
     end
+
+    it "does not lose information when an error occurs"
+        autocmd BufWritePre *.py 0,$!yapf
+        edit! t/syntax_errors.py
+        write!
+    end
 end
diff --git a/t/syntax_errors.py b/t/syntax_errors.py
Original file line number	Diff line number	Diff line change
Expand Up		@@ -123,3 +123,5 @@ Alternatively alternatively yapf could be set as the ``equalprg``:
		and reformat the whole file with ``gg=G`` or a single line with ``=``.

		.. _gq{motion}: https://github.com/vim/vim/blob/b182b40080a23ea1e1ffa28ea03b412174a236bb/runtime/doc/change.txt#L1299

		Note: if ``vim-yapf`` is used in this way, any errors will overwrite the current buffer. Make sure to check the buffer for errors before saving. Regardless, the ``undo`` command should work.
Copy link Collaborator melissachang Jul 17, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. The problem is when I type "ZZ". In that case, the vim window closes; I don't see the error; and my file contents are lost. Is there any way to implement this without having "ZZ" lose file contents? Maybe write to a new buffer instead of overwrite current buffer? At the very least, append to current buffer? Actually, ideal for me would be if yapf just silently failed with syntax errors. yapf exit code is not 0 No vim buffers are modified Copy link Collaborator melissachang Jul 17, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Is it possible to print yapf syntax error to vim stdout or stderr, rather than write to a vim buffer? Copy link Collaborator melissachang Aug 9, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Alright, I found a workaround: https://gist.github.com/nepsilon/003dd7cfefc20ce1e894db9c94749755 So here's what I would like to see: Note: if `vim-yapf` is used in this way, any errors will overwrite the current buffer. Make sure to check the buffer for errors before saving. If you save with `:w`, `:undo` will revert the buffer. If you save with `:ZZ`, the saved file will be overwritten with the yapf syntax error. It is recommended to Auto-backup your files so you can recover your work. Copy link Collaborator melissachang Aug 9, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Note even with the workaround, I lose the most recent changes (the ones that caused error), but it's better than nothing