fix(command.ts): align order of variables with error message #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, thanks for spotting this. Just looks like you need to pass the commit lint and then we can get this merged 👌🏻 |
I spent a lot of time debugging failed snapshot tests until I found out that the variables for expected and observed image dimensions are swapped in the error message. Can be tested by updating the snapshot and then checking which values change in the message. Fix is to just put them in the correct order.
|
@simonsmith thanks for the quick reaction! Checks are green now, so as far as I am concerned, merge away 😄 |
|
@ramonziai Perfect, thank you! |
|
🎉 This PR is included in version 9.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent a lot of time debugging failed snapshot tests until I found out that the variables for expected and observed image dimensions are swapped in the error message. Can be tested by updating the snapshot and then checking which values change in the message. Fix is to just put them in the correct order.