properly handle WCS when slicing Enmap #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the proper WCS modifications one must make when slicing an enmap. This mostly involves modifying the CRPIX entry of the WCS structure. For example,
If the stride is not 1, then CDELT can also change.
In Julia, there is a syntactical distinction between slicing as copy and slicing as view. The usual array slice always copies! To avoid copies, you have to use
@view
or theview(...)
function. This PR also provides the appropriate WCS manipulations when a view is made of an Enmap.