Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This very large PR removes the old projection types, which were redundant with the WCS. Instead, this PR introduces a custom immutable WCS struct,
One can choose between this or the C-based
WCS.WCSTransform
, and using this WCS makes certain parts of the package substantially faster. This struct stays on the stack, consists of 7 numbers, and is definitely more cache-friendly than the kb-sized WCS header we were dragging around. This also means that manipulation of small Enmaps, particularly ones that contain views, isn't dominated by repeatedly copying the WCS header. Although a lot of code changed, I don't think this is breaking.We are losing some info since the WCS header can have lots of things in it. I should try to deal with this appropriately in the IO routines, probably by providing an option to convert back or follow a WCS template. @guanyilun just a quick clarification, is the default behavior to always convert to POLCCONV to COSMO, and then write to disk as COSMO?