fix bug in sub #47
Merged
fix bug in sub #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 84.64% 84.70% +0.05%
==========================================
Files 6 6
Lines 534 536 +2
==========================================
+ Hits 452 454 +2
Misses 82 82
Continue to review full report at Codecov.
|
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #42. I originally thought I can get away with simply changing axis, but this causes problem in field such as wcs.lin which stores a transformation matrix. A mismatch in naxis will result in overflow. Here I do it properly by using wcssub function in libwcs.