Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.9 #57

Merged
merged 7 commits into from
Sep 23, 2024
Merged

Support Python 3.9 #57

merged 7 commits into from
Sep 23, 2024

Conversation

TaiSakuma
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 79.13043% with 24 lines in your changes missing coverage. Please review.

Project coverage is 81.94%. Comparing base (69d8fcd) to head (a7bdb24).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
tests/stack/async/refs/dunder.py 0.00% 9 Missing ⚠️
tests/stack/async/refs/nested.py 0.00% 9 Missing ⚠️
tests/stack/sync/refs/dunder.py 81.81% 1 Missing and 1 partial ⚠️
tests/stack/sync/refs/nested.py 81.81% 1 Missing and 1 partial ⚠️
tests/stack/async/runner.py 91.66% 0 Missing and 1 partial ⚠️
tests/stack/sync/runner.py 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   81.33%   81.94%   +0.60%     
==========================================
  Files          39       39              
  Lines        1404     1407       +3     
  Branches      264      268       +4     
==========================================
+ Hits         1142     1153      +11     
+ Misses        234      221      -13     
- Partials       28       33       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TaiSakuma TaiSakuma merged commit fe4dcbd into main Sep 23, 2024
25 checks passed
@glensc
Copy link

glensc commented Sep 24, 2024

alright, something this I was just recently asked via issue:

@glensc
Copy link

glensc commented Sep 24, 2024

Imho not nice to commit dead code (commented out code) to project.

What I would do myself, is create immediately pr that drops 3.9 support and let it be in Draft state until the time comes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants