Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create g32influx script #153

Merged
merged 24 commits into from
Jul 17, 2020
Merged

Create g32influx script #153

merged 24 commits into from
Jul 17, 2020

Conversation

BrianJKoopman
Copy link
Member

Description

This PR introduces the g32influx script, which publishes data from .g3 files to InfluxDB.

Motivation and Context

The script was originally motivated by the need to upload old .g3 files from before the InfluxdB Publisher was written and InfluxDB was even in use. Now it is motivated by the desire to re-upload entire sets of .g3 files to a fresh InfluxDB instance in order to fix invalid field names previously written to .g3 files. (See simonsobs/socs#87)

How Has This Been Tested?

This has been run on recent subset of HK data from the Yale OCS setup. This includes v0 and v1 .g3 files. Data was then visually inspected in Grafana, viewing the new database with uploaded data from .g3 file.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Unless I am preparing a release, I have opened this PR onto the develop branch.

@BrianJKoopman BrianJKoopman added the enhancement New feature or request label Jul 17, 2020
BrianJKoopman and others added 24 commits July 17, 2020 13:56
Add argparse for passing in targets to move out of testing phase. Swap to a
nestable progress bar, and add documentation.
This incorporates several changes from #107, but with some modifications. Most
notably it includes format_timeline(), which comes with a dramatic performance
increase, both by publishing all fields that share a timeline simultaneously and
by utilizing InfluxDB's line protocol, which is faster than the previously used
json based protocol.

We maintain the use of a local sqlite DB instead of switching to using InfluxDB
to track published .g3 files. We also remove the use of an additional md5sum
tag on data uploaded with this script.

Many thanks to @ahincks for the work this was based on.
@BrianJKoopman
Copy link
Member Author

BrianJKoopman commented Jul 17, 2020

Since this exclusively adds a new feature, with no changes to existing code or conflicts with existing functionality -- and would be immediately useful to work on SOCS -- I'm going to go ahead and merge this. Feel free to open bug reports/feature requests related to g32influx as issues.

@BrianJKoopman BrianJKoopman merged commit 5993b6a into develop Jul 17, 2020
@BrianJKoopman BrianJKoopman deleted the g32influx-script branch July 17, 2020 18:07
@BrianJKoopman BrianJKoopman added this to the v0.7.0 milestone Jul 20, 2020
@BrianJKoopman BrianJKoopman mentioned this pull request Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant