Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The HK Aggregator depends on spt3g/so3g, as a result the tests related to the aggregator fail during test collection if spt3g and so3g are not installed. This PR protects the relevant imports and runs a test for those imports. If the import test fails it uses the
pytest-dependency
plugin to skip the so3g/spt3g dependent tests.This allows other tests to run, while reporting failed tests when an import test is run. For example, on a fresh system with just ocs and the requirements listed in
requirements.txt
installed testing yields:Motivation and Context
Fixes #209.
How Has This Been Tested?
This has been run on a fresh Ubuntu 20.04 system with just ocs and the modules listed in the
requirements.txt
file installed. Tests now complete, with failures where so3g imports are tested.Types of changes
Checklist:
develop
branch.