Only perform check on param if value is given #228
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a value isn't given, the check likely isn't valid. This will cause problems
if the decorated method is imported, for instance in any testing, as the value
will be None on import, which will fail simple checks like x < 100.
Example traceback when this happens:
Motivation and Context
No open issue for this bug, found when developing tests for an socs Agent.
How Has This Been Tested?
The import in question above passes with this change.
Types of changes
Checklist:
develop
branch.