Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace docker login with docker/login-action #267

Merged
merged 1 commit into from
May 9, 2022
Merged

Replace docker login with docker/login-action #267

merged 1 commit into from
May 9, 2022

Conversation

BrianJKoopman
Copy link
Member

Description

This is a more secure way to login to a registry.

Motivation and Context

Just propagating workflow improvement from simonsobs/socs#289.

How Has This Been Tested?

Been used effectively in socs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Unless I am preparing a release, I have opened this PR onto the develop branch.

@BrianJKoopman BrianJKoopman merged commit 375104a into develop May 9, 2022
@BrianJKoopman BrianJKoopman deleted the koopman/docker-login-action branch May 9, 2022 15:33
@BrianJKoopman BrianJKoopman mentioned this pull request Jun 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BrianJKoopman