Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate blocks for each registered operation #312

Merged
merged 5 commits into from
Mar 8, 2023
Merged

Conversation

jlashner
Copy link
Collaborator

@jlashner jlashner commented Dec 15, 2022

Changes registry block structure so that each operation has its own block.

Description

It is possible for the operation list of an agent to change, if that agent is updated without restarting the registry. This will crash the registry and prevent it from publishing data since the block-structure of the feed depends on the available agents. This changes the registry so that each operation has its own block, allowing for the operation list to change without crashing the registry.

Motivation and Context

Solves issues where updating agents without restarting the registry causes it to crash.
Resolves #311.

How Has This Been Tested?

Ran registry tests locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrianJKoopman BrianJKoopman changed the base branch from develop to main December 19, 2022 14:58
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long for me to test. I was wondering if there were any implications past the registry in the system of splitting up the blocks and wanted to AB test opening files with and w/o the patch. In doing so I did notice a bug in the field name assignment.

ocs/agents/registry/agent.py Outdated Show resolved Hide resolved
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Tested one more time, things look good to me now!

@BrianJKoopman BrianJKoopman merged commit 92371ff into main Mar 8, 2023
@BrianJKoopman BrianJKoopman deleted the issue311 branch March 8, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCS registry fails when block structure changes
2 participants