Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional codecov debugging #413

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Conversation

BrianJKoopman
Copy link
Member

Description

This is just more debugging of switching to codecov. I found a mistake in how I was uploading the CODECOV_TOKEN to the repo, so this should hopefully go smoothly now.

Motivation and Context

#412 didn't help at all really.

How Has This Been Tested?

The test will be whether this uploads properly at all from the PR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Oct 21, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@BrianJKoopman BrianJKoopman changed the title Replace coveralls with codecov Additional codecov debugging Oct 21, 2024
@BrianJKoopman
Copy link
Member Author

Okay, I think I was also getting bit by the secrets not passing to the reusable workflow once we merged to main. I'm going to merge this to test that new inherit line works. Then I expect at least one, maybe two more PRs to sort out replacing coveralls. Sorry for all the noise.

@BrianJKoopman BrianJKoopman merged commit b3355d7 into main Oct 21, 2024
6 checks passed
@BrianJKoopman BrianJKoopman deleted the koopman/more-coveralls-debugging branch October 21, 2024 21:30
@BrianJKoopman BrianJKoopman mentioned this pull request Oct 22, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant