-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement automatic socket reconnection for LS372 and SCPI agents #325
Open
erfz
wants to merge
19
commits into
simonsobs:develop
Choose a base branch
from
erfz:emulator_disconnect
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… need to test behavior on hardware
…-read, since that read attempt should not be satisfiable
…lly for graceful socket shutdown)
for more information, see https://pre-commit.ci
48 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented primarily in their respective drivers, these changes cause LS372 and SCPI agents to attempt to re-establish a socket connection whenever a read/write unexpectedly fails. As written, any read/write attempts made just prior to a connection failure are "thrown away" and a
ConnectionResetError
is always thrown following a successful reconnection. This can be caught by agent code to react accordingly. In particular, the acquisition Processes in these agents (acq
andmonitor_output
respectively) have been adjusted to automatically restart acquisition/monitoring upon reconnection.Motivation and Context
This achieves the desired behavior in these agents of not needing to manually restart long-running Processes if there is a momentary connection failure.
How Has This Been Tested?
Additional test cases have been written that roughly simulate a connection failure. The LS372 changes have been tested with the physical device.
Types of changes
Checklist:
develop
branch.