Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed LS240 connection drop crashing acq process #430

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

davidvng
Copy link
Contributor

@davidvng davidvng commented Apr 3, 2023

Changed agent code to handle connection drops without crashing the acq process.

Description

When a connection drop occurs, the process will stop the current loop and attempt to run init_lakeshore to re-initialize the data fields. The re-initialization will try once every second until reconnection and then the loop continues.

Motivation and Context

Addresses connection drop issues seen across all groups using LS240's.
Possibly fixes #418 and any other old issues?

How Has This Been Tested?

Tested by pulling USB connection and re-connecting. Testing environment is a nuc machine at Yale running Ubuntu 18.04 (required for Anyplace coolgear drivers to work). Works on LS240's connected either directly to nuc or to the Anyplace device.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent: ls240 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serial collisions cause LS240 to respond with garbage and crashes the agent
1 participant