Fix some time-out / delay bugs in ACU agent #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timeout has been marginal recently since the max platform speeds on SATP1 & 3 were lowered to 0.5 deg/s, which was the vel used to estimate the timeout.
This can't be detected other than through the track stack size.
Could this be the *last* bug in scanning?!
|
I've just added two more fixes which should greatly improve quality of life. I would like to get this deployed ASAP, as several of these bugs have been annoying SATP1 testing. |
hnakata-JP
pushed a commit
that referenced
this pull request
Apr 12, 2024
* ACU: increase overall timeout The timeout has been marginal recently since the max platform speeds on SATP1 & 3 were lowered to 0.5 deg/s, which was the vel used to estimate the timeout. * ACU: allow more time for _run_scan to enter ProgramTrack mode * ACU: suppress Sun escape (and logging) if platform not moveable * ACU: go_to_axes patiently waits for the warning horn to sound * ACU: minor tweaks / fixes for last few bug fix commits * ACU: add trap for case where track is getting dropped This can't be detected other than through the track stack size. * ACU: fix bug where scan could exit prematurely Could this be the *last* bug in scanning?!
BrianJKoopman
pushed a commit
that referenced
this pull request
May 8, 2024
* ACU: increase overall timeout The timeout has been marginal recently since the max platform speeds on SATP1 & 3 were lowered to 0.5 deg/s, which was the vel used to estimate the timeout. * ACU: allow more time for _run_scan to enter ProgramTrack mode * ACU: suppress Sun escape (and logging) if platform not moveable * ACU: go_to_axes patiently waits for the warning horn to sound * ACU: minor tweaks / fixes for last few bug fix commits * ACU: add trap for case where track is getting dropped This can't be detected other than through the track stack size. * ACU: fix bug where scan could exit prematurely Could this be the *last* bug in scanning?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Key features:
Motivation and Context
Addresses issues reported in #617, #619, #620. There are a few mysteries remaining but I think we should close these and get clean measurements of any new problems.
Resolves #617.
Resolves #619.
Resolves #620.
How Has This Been Tested?
Tested on SATP1. "Not moveable" suppression of Sun avoidance escapes was simulated with a time-based hack.
I am comfortable running this on any platform as is.
Types of changes
Checklist: