Add bias wave task to pysmurf-controller agent #633
Conversation
adding in code for bias waves. Essentially copying the bias step code block and modifying for bias wave analysis.
for more information, see https://pre-commit.ci
| session data object. See the `sodetlib bias wave docs page | ||
|
|
||
| NEED TO CREATE DOCS PAGE AND INSERT HERE | ||
|
|
||
| for more information on bias wave and what kwargs can be passed in. |
There was a problem hiding this comment.
Lets leave this out until the docs page exists
There was a problem hiding this comment.
fixed in latest commit
added in param for "tag" arg for bias wave (and biasstep... seemed to be missing there too). Rmoved docstring for nonexistent documentation.
for more information, see https://pre-commit.ci
registered OCS operation at bottom of file
I've made the requested changes, and registered the OCS operation at the end of the file! This should be good to test, I will interface with the site team to see when a good time for me to do that will be. |
There was a problem hiding this comment.
Looks good to me, there was a stray decorator added to another task that should be removed (see below.)
Also, this bias wave code isn't merged upstream in sodetlib yet, so those tests are going to keep failing, and the build isn't going to work. That should be merged first.
BrianJKoopman
changed the title
This was merged in sodetlib here can we rerun ci tests somehow? |
|
Merging in the latest |
|
@BrianJKoopman this test failure doesn’t seem related to anything we added. |
Yup, agreed. Not sure why this is cropping back up suddenly, but #643 should work around the issue here. |
|
Alright, #650 dropped the unrelated tests that are being flaky. Merge in the latest |
|
Sorry, one more merge of the latest |
adding in code for bias waves. Essentially copying the bias step code block and modifying for bias wave analysis.
Description
adding in agent task for bias waves in similar form to bias step
Motivation and Context
Needed to be able to run bias waves in nextline