-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safer grip and add ungrip #646
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments from me related to documentation and the handling of session data in the new ungrip code. I'm also wondering if this has been tested yet.
I finished incorporating the comments from @BrianJKoopman and testing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes related to my comments look good. @jlashner, did you still want to take a look at this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Kyohei, I read this through and think it looks great, so I approve to merge as long as its been tested!
Thanks! Yes, I tested this in satp3. |
Description
Motivation and Context
https://github.com/simonsobs/chwp-discussions/discussions/17
How Has This Been Tested?
We need to test
Types of changes
Checklist: