Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run nan_to_num on quantiles #655

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Run nan_to_num on quantiles #655

merged 1 commit into from
Apr 12, 2024

Conversation

jlashner
Copy link
Collaborator

@jlashner jlashner commented Apr 11, 2024

Replaces nans and +- inf in bias step quantile functions.

Description

This should fix the issue with infs getting passed to session.data reported here: #645

Motivation and Context

Resolves #645, which has been occasionally crashing the schedule.

How Has This Been Tested?

I've tested running the line w/ fake data to make sure there are no typos.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @jlashner!

@BrianJKoopman BrianJKoopman merged commit 741215a into main Apr 12, 2024
5 checks passed
@BrianJKoopman BrianJKoopman deleted the fix_pysmurf_infs branch April 12, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with pysmurf-controller publishing infs
2 participants