What functions should work when pysmurf is offline? #356

Prakamya01 · 2023-06-14T19:04:15Z

Prakamya01
Jun 14, 2023

I tried defining an instance of pysmurf offline and then tried running S.decode_data, but it gave me NoneType object is not subscriptable. I'm just wondering if this makes sense and if this is a function that can't be run while offline. If so, is there a place where functions that can or can't be run offline are documented?

Answered by jlashner

Jun 20, 2023

I'm just going to link shawn's reply from slaclab/pysmurf#674 as the answer for this for now, but feel free to re-open or change that if there's more you'd like to discuss about this!

One way shawn / prakamya have figured out to load old tracking data with pysmurf in offline mode is to hard-code the tone_frequency_offset array so that it doesn't pull from rogue, as can be seen below:

S.get_tone_frequency_offset_mhz = lambda band : np.array([   0. ,  307.2,  153.6, -153.6,   76.8, -230.4,  230.4,  -76.8,
         38.4, -268.8,  192. , -115.2,  115.2, -192. ,  268.8,  -38.4,
         19.2, -288. ,  172.8, -134.4,   96. , -211.2,  249.6,  -57.6,
         57.6, -249.6,  211.2,  -96. ,  134.4,…

View full answer

msilvafe · 2023-06-14T19:10:48Z

msilvafe
Jun 14, 2023
Collaborator

I have used decode_single_channel while running in offline mode, so I expect decode_data to work. Are you loading flux ramp data? Can you share how you're getting your smurf control object, the full traceback, and the couple lines of code around where you get this error?

2 replies

Prakamya01 Jun 14, 2023
Author

I ran:

import pysmurf.client
S = pysmurf.client.SmurfControl(offline=True)
(f,df,strobe)=S.decode_data('/data/smurf_data/tracking_setup/1671824252_tracking_setup/outputs/1671824252.dat')

on smurf-srv24

Full trackback

`TypeError                                 Traceback (most recent call last)
/var/folders/th/g5xg7fns491dg9vw8nxz_bx9_1wqnw/T/ipykernel_31223/3259092039.py in <module>
----> 1 (f,df,strobe)=S.decode_data('/Users/prak0819/so/data/pton/tracking_setup/1671824252_tracking_setup/outputs/1671824252.dat')

~/opt/anaconda3/lib/python3.9/site-packages/pysmurf/client/util/pub.py in wrapper(S, pub_action, *args, **kwargs)
     48                     S.pub._action_ts = S.get_timestamp()
     49 
---> 50                 rv = func(S, *args, **kwargs)
     51 
     52             finally:

~/opt/anaconda3/lib/python3.9/site-packages/pysmurf/client/util/smurf_util.py in decode_data(self, filename, swapFdF, recast, truncate)
    637             dftmp = np.zeros_like(ftmp)
    638 
--> 639             processed_ind = self.get_processed_channels()
    640             ftmp[:, processed_ind] = f[:nsamp]
    641             dftmp[:, processed_ind] = df[:nsamp]

~/opt/anaconda3/lib/python3.9/site-packages/pysmurf/client/util/smurf_util.py in get_processed_channels(self, channel_orderfile)
   2372         n_chan = self.get_number_channels()
   2373         n_cut = (n_chan - n_proc)//2
-> 2374         return np.sort(self.get_channel_order(
   2375             channel_orderfile=channel_orderfile)[n_cut:-n_cut])
   2376 

~/opt/anaconda3/lib/python3.9/site-packages/pysmurf/client/util/smurf_util.py in get_channel_order(self, band, channel_orderfile)
   2341             # the list of bands specified in experiment.cfg.
   2342             bands = self._bands
-> 2343             band = bands[0]
   2344 
   2345         tone_freq_offset = self.get_tone_frequency_offset_mhz(band)

TypeError: 'NoneType' object is not subscriptable`

jlashner Jun 14, 2023
Maintainer

oh ya maybe you can work around this by running like S._bands = np.arange(8)?

jlashner · 2023-06-14T19:15:40Z

jlashner
Jun 14, 2023
Maintainer

I think this agrees with what I've seen in the past... where S.decode_data relies on something in the pysmurf instance that isn't available in offline mode, making reading tracking files offline difficult. This is partially why sodetlib saves tracking data information to its own files.

It would be great if it were officially documented which functions work in offline mode, but unfortunately that would have to come from pysmurf and I doubt that's a priority for them. If you want to keep track of working functions somewhere, that seems like it would be a great discussions post that could eventually turn into a docs page!!

4 replies

msilvafe Jun 14, 2023
Collaborator

Oh wow, that is a bummer...but good that @Prakamya01 can rely on using the data saved by sodetlib! Maybe we can open a pysmurf issue about this though even if it's low on the list to have it tracked over there too?

Prakamya01 Jun 14, 2023
Author

Yeah, I can open an issue if it's helpful

jlashner Jun 14, 2023
Maintainer

oh I think I may already have one open haha: slaclab/pysmurf#674

jlashner Jun 14, 2023
Maintainer

from 2021 😬 so much for this being fixed in a reasonable timescale

jlashner · 2023-06-20T02:30:59Z

jlashner
Jun 20, 2023
Maintainer

I'm just going to link shawn's reply from slaclab/pysmurf#674 as the answer for this for now, but feel free to re-open or change that if there's more you'd like to discuss about this!

One way shawn / prakamya have figured out to load old tracking data with pysmurf in offline mode is to hard-code the tone_frequency_offset array so that it doesn't pull from rogue, as can be seen below:

S.get_tone_frequency_offset_mhz = lambda band : np.array([   0. ,  307.2,  153.6, -153.6,   76.8, -230.4,  230.4,  -76.8,
         38.4, -268.8,  192. , -115.2,  115.2, -192. ,  268.8,  -38.4,
         19.2, -288. ,  172.8, -134.4,   96. , -211.2,  249.6,  -57.6,
         57.6, -249.6,  211.2,  -96. ,  134.4, -172.8,  288. ,  -19.2,
          9.6, -297.6,  163.2, -144. ,   86.4, -220.8,  240. ,  -67.2,
         48. , -259.2,  201.6, -105.6,  124.8, -182.4,  278.4,  -28.8,
         28.8, -278.4,  182.4, -124.8,  105.6, -201.6,  259.2,  -48. ,
         67.2, -240. ,  220.8,  -86.4,  144. , -163.2,  297.6,   -9.6,
          4.8, -302.4,  158.4, -148.8,   81.6, -225.6,  235.2,  -72. ,
         43.2, -264. ,  196.8, -110.4,  120. , -187.2,  273.6,  -33.6,
         24. , -283.2,  177.6, -129.6,  100.8, -206.4,  254.4,  -52.8,
         62.4, -244.8,  216. ,  -91.2,  139.2, -168. ,  292.8,  -14.4,
         14.4, -292.8,  168. , -139.2,   91.2, -216. ,  244.8,  -62.4,
         52.8, -254.4,  206.4, -100.8,  129.6, -177.6,  283.2,  -24. ,
         33.6, -273.6,  187.2, -120. ,  110.4, -196.8,  264. ,  -43.2,
         72. , -235.2,  225.6,  -81.6,  148.8, -158.4,  302.4,   -4.8,
          2.4, -304.8,  156. , -151.2,   79.2, -228. ,  232.8,  -74.4,
         40.8, -266.4,  194.4, -112.8,  117.6, -189.6,  271.2,  -36. ,
         21.6, -285.6,  175.2, -132. ,   98.4, -208.8,  252. ,  -55.2,
         60. , -247.2,  213.6,  -93.6,  136.8, -170.4,  290.4,  -16.8,
         12. , -295.2,  165.6, -141.6,   88.8, -218.4,  242.4,  -64.8,
         50.4, -256.8,  204. , -103.2,  127.2, -180. ,  280.8,  -26.4,
         31.2, -276. ,  184.8, -122.4,  108. , -199.2,  261.6,  -45.6,
         69.6, -237.6,  223.2,  -84. ,  146.4, -160.8,  300. ,   -7.2,
          7.2, -300. ,  160.8, -146.4,   84. , -223.2,  237.6,  -69.6,
         45.6, -261.6,  199.2, -108. ,  122.4, -184.8,  276. ,  -31.2,
         26.4, -280.8,  180. , -127.2,  103.2, -204. ,  256.8,  -50.4,
         64.8, -242.4,  218.4,  -88.8,  141.6, -165.6,  295.2,  -12. ,
         16.8, -290.4,  170.4, -136.8,   93.6, -213.6,  247.2,  -60. ,
         55.2, -252. ,  208.8,  -98.4,  132. , -175.2,  285.6,  -21.6,
         36. , -271.2,  189.6, -117.6,  112.8, -194.4,  266.4,  -40.8,
         74.4, -232.8,  228. ,  -79.2,  151.2, -156. ,  304.8,   -2.4,
          1.2, -306. ,  154.8, -152.4,   78. , -229.2,  231.6,  -75.6,
         39.6, -267.6,  193.2, -114. ,  116.4, -190.8,  270. ,  -37.2,
         20.4, -286.8,  174. , -133.2,   97.2, -210. ,  250.8,  -56.4,
         58.8, -248.4,  212.4,  -94.8,  135.6, -171.6,  289.2,  -18. ,
         10.8, -296.4,  164.4, -142.8,   87.6, -219.6,  241.2,  -66. ,
         49.2, -258. ,  202.8, -104.4,  126. , -181.2,  279.6,  -27.6,
         30. , -277.2,  183.6, -123.6,  106.8, -200.4,  260.4,  -46.8,
         68.4, -238.8,  222. ,  -85.2,  145.2, -162. ,  298.8,   -8.4,
          6. , -301.2,  159.6, -147.6,   82.8, -224.4,  236.4,  -70.8,
         44.4, -262.8,  198. , -109.2,  121.2, -186. ,  274.8,  -32.4,
         25.2, -282. ,  178.8, -128.4,  102. , -205.2,  255.6,  -51.6,
         63.6, -243.6,  217.2,  -90. ,  140.4, -166.8,  294. ,  -13.2,
         15.6, -291.6,  169.2, -138. ,   92.4, -214.8,  246. ,  -61.2,
         54. , -253.2,  207.6,  -99.6,  130.8, -176.4,  284.4,  -22.8,
         34.8, -272.4,  188.4, -118.8,  111.6, -195.6,  265.2,  -42. ,
         73.2, -234. ,  226.8,  -80.4,  150. , -157.2,  303.6,   -3.6,
          3.6, -303.6,  157.2, -150. ,   80.4, -226.8,  234. ,  -73.2,
         42. , -265.2,  195.6, -111.6,  118.8, -188.4,  272.4,  -34.8,
         22.8, -284.4,  176.4, -130.8,   99.6, -207.6,  253.2,  -54. ,
         61.2, -246. ,  214.8,  -92.4,  138. , -169.2,  291.6,  -15.6,
         13.2, -294. ,  166.8, -140.4,   90. , -217.2,  243.6,  -63.6,
         51.6, -255.6,  205.2, -102. ,  128.4, -178.8,  282. ,  -25.2,
         32.4, -274.8,  186. , -121.2,  109.2, -198. ,  262.8,  -44.4,
         70.8, -236.4,  224.4,  -82.8,  147.6, -159.6,  301.2,   -6. ,
          8.4, -298.8,  162. , -145.2,   85.2, -222. ,  238.8,  -68.4,
         46.8, -260.4,  200.4, -106.8,  123.6, -183.6,  277.2,  -30. ,
         27.6, -279.6,  181.2, -126. ,  104.4, -202.8,  258. ,  -49.2,
         66. , -241.2,  219.6,  -87.6,  142.8, -164.4,  296.4,  -10.8,
         18. , -289.2,  171.6, -135.6,   94.8, -212.4,  248.4,  -58.8,
         56.4, -250.8,  210. ,  -97.2,  133.2, -174. ,  286.8,  -20.4,
         37.2, -270. ,  190.8, -116.4,  114. , -193.2,  267.6,  -39.6,
         75.6, -231.6,  229.2,  -78. ,  152.4, -154.8,  306. ,   -1.2])

f, df, strobe=S.decode_data('/data/smurf_data/tracking_setup/1671824252_tracking_setup/outputs/1671824252.dat')

This may add a small offset to the f values, but the np.ptp(f) and np.ptp(df) should still be correct.

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

What functions should work when pysmurf is offline? #356

{{title}}

Replies: 3 comments 6 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

What functions should work when pysmurf is offline? #356

Prakamya01 Jun 14, 2023

Replies: 3 comments · 6 replies

msilvafe Jun 14, 2023 Collaborator

Prakamya01 Jun 14, 2023 Author

jlashner Jun 14, 2023 Maintainer

jlashner Jun 14, 2023 Maintainer

msilvafe Jun 14, 2023 Collaborator

Prakamya01 Jun 14, 2023 Author

jlashner Jun 14, 2023 Maintainer

jlashner Jun 14, 2023 Maintainer

jlashner Jun 20, 2023 Maintainer

Prakamya01
Jun 14, 2023

Replies: 3 comments 6 replies

msilvafe
Jun 14, 2023
Collaborator

Prakamya01 Jun 14, 2023
Author

jlashner Jun 14, 2023
Maintainer

jlashner
Jun 14, 2023
Maintainer

msilvafe Jun 14, 2023
Collaborator

Prakamya01 Jun 14, 2023
Author

jlashner Jun 14, 2023
Maintainer

jlashner Jun 14, 2023
Maintainer

jlashner
Jun 20, 2023
Maintainer