Support usage of SMURF_CONFIG_DIR instead of OCS_CONFIG_DIR #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlashner
force-pushed
the
smurf-config-dir-env
branch
from
b915071 to
fa2097f
Compare
|
Thanks Brian, I clarified the docs with regards to the configuration directory and changed wording to be more general. |
BrianJKoopman
approved these changes
Dec 12, 2024
|
This has been tested with the new deployment configuration on smurf-srv20-satp1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for an environment variable $SMURF_CONFIG_DIR which will replace $OCS_CONFIG_DIR if it is specified.
The OCS_CONFIG_DIR technically needs to be the directory where the OCS default.yaml file exists, which for most lab-setups is the same as the directory where the sys_config.yml and smurf-config files live. However for deployed servers these are different. We've been getting around by always manually specifying the ocs site-config file on deployment servers, but this will no longer be possible when the smurf-server environment is managed more by site-computing.
Moving forward, we will want to point to the smurf-configuration directory using a separate environment variable, $SMURF_CONFIG_DIR, which defaults to OCS_CONFIG_DIR if it is not set.