Skip to content

Commit

Permalink
chore(eslint-config-ng): more tweaks to strict config
Browse files Browse the repository at this point in the history
  • Loading branch information
ersimont committed Jan 21, 2023
1 parent 7e010c0 commit 1a0ac06
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 6 deletions.
3 changes: 3 additions & 0 deletions projects/eslint-config-ng/strict.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
],
"accessor-pairs": "off",
"class-methods-use-this": "off",
"max-params": "off",
"new-cap": "off", // This errs on decorators

// Better compatibility with s-libs
Expand Down Expand Up @@ -72,6 +73,7 @@
"@typescript-eslint/prefer-readonly": "off",
"@typescript-eslint/prefer-readonly-parameter-types": "off",
"@typescript-eslint/require-await": "off",
"@typescript-eslint/strict-boolean-expressions": "off",
"capitalized-comments": "off",
"id-length": "off",
"line-comment-position": "off",
Expand All @@ -80,6 +82,7 @@
"multiline-comment-style": "off",
"no-await-in-loop": "off",
"no-console": "off",
"no-continue": "off",
"no-else-return": "off",
"no-implicit-coercion": ["error", { "allow": ["!!", "+"] }],
"no-inline-comments": "off",
Expand Down
1 change: 0 additions & 1 deletion projects/micro-dash/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
"func-names": "off",
"max-depth": "off",
"max-lines-per-function": "off",
"max-params": "off",
"no-bitwise": "off",
"no-eq-null": "off",
"no-multi-assign": "off",
Expand Down
2 changes: 0 additions & 2 deletions projects/micro-dash/src/lib/function/curry.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ import { bind } from 'lodash';
import { ObjectWith } from '../interfaces';
import { curry } from './curry';

/* eslint-disable max-params */

describe('curry()', () => {
//
// stolen from https://github.com/lodash/lodash
Expand Down
1 change: 0 additions & 1 deletion projects/ng-core/src/lib/control-synchronizer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ export class ControlSynchronizer {
control.addValidators(() => this.#errorsFromPartner);
}

// eslint-disable-next-line max-params
static synchronize(
outer: AbstractControl,
inner: AbstractControl,
Expand Down
2 changes: 1 addition & 1 deletion projects/ng-core/src/lib/directive-superclass.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export abstract class DirectiveSuperclass
}

/**
* Binds an observable to one of this directive's instance variables. When the observable emits the instance variable will be updated, and change detection will be triggered to propagate any changes. Use this an an alternative to repeating `| async` multiple times in your template.
* Binds an observable to one of this directive's instance variables. When the observable emits the instance variable will be updated, and change detection will be triggered to propagate any changes. Use this as an alternative to repeating `| async` multiple times in your template.
*/
bindToInstance<K extends keyof this>(
key: K,
Expand Down
1 change: 0 additions & 1 deletion projects/rxjs-core/src/lib/subscription-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ export function mixInSubscriptionManager<B extends Constructor>(Base: B) {
return class extends Base implements Unsubscribable {
#subscriptions = new Subscription();

// eslint-disable-next-line max-params
subscribeTo<T>(
observable: Observable<T>,
next?: (value: T) => void,
Expand Down

0 comments on commit 1a0ac06

Please sign in to comment.