feat(rxjs-core): add SubscriptionManager.manage()

simontonsoftware · Feb 3, 2021 · 4b1aad6 · 4b1aad6
1 parent 317972c
commit 4b1aad6
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/projects/rxjs-core/src/lib/subscription-manager.spec.ts b/projects/rxjs-core/src/lib/subscription-manager.spec.ts
@@ -93,6 +93,17 @@ describe('SubscriptionManager', () => {
     });
   });
 
+  describe('.manage()', () => {
+    it('causes the manager to manage the passed-in subscription', () => {
+      const subject = new Subject();
+      manager.manage(subject.subscribe(next));
+
+      manager.unsubscribe();
+      subject.next();
+      expect(next).not.toHaveBeenCalled();
+    });
+  });
+
   describe('.unsubscribe()', () => {
     it('stop callbacks', () => {
       const subject1 = new Subject();

diff --git a/projects/rxjs-core/src/lib/subscription-manager.ts b/projects/rxjs-core/src/lib/subscription-manager.ts
@@ -12,6 +12,7 @@ import { Observable, Subscription, Unsubscribable } from 'rxjs';
  * }
  * ```
  */
+/* eslint-disable max-lines-per-function */
 // tslint:disable-next-line:typedef
 export function mixInSubscriptionManager<B extends Constructor>(Base: B) {
   return class extends Base implements Unsubscribable {
@@ -32,6 +33,10 @@ export function mixInSubscriptionManager<B extends Constructor>(Base: B) {
       );
     }
 
+    manage(subscription: Subscription): void {
+      this.#subscriptions.add(subscription);
+    }
+
     unsubscribe(): void {
       this.#subscriptions.unsubscribe();
       this.#subscriptions = new Subscription();