Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle Python and install datasette in a virtual environment on startup #27

Merged
merged 6 commits into from
Aug 31, 2021

Conversation

simonw
Copy link
Owner

@simonw simonw commented Aug 31, 2021

Refs #25.

@simonw
Copy link
Owner Author

simonw commented Aug 31, 2021

I'm going to see what happens if I have the test.yml workflow run npm run dist at the end and then attach the generated .dmg file as an artifact.

@simonw simonw added this to the First public installer release milestone Aug 31, 2021
@simonw
Copy link
Owner Author

simonw commented Aug 31, 2021

That took longer than 5 minutes (total including running the tests) so it timed out.

@simonw
Copy link
Owner Author

simonw commented Aug 31, 2021

Got this error:

⨯ GitHub Personal Access Token is not set, neither programmatically, nor using env "GH_TOKEN"

@simonw
Copy link
Owner Author

simonw commented Aug 31, 2021

electron-userland/electron-builder#1693 (comment) says I should pass --publish=never

@simonw
Copy link
Owner Author

simonw commented Aug 31, 2021

OK that seemed to work... there's a 150MB DMG artifact attached to https://github.com/simonw/datasette-app/actions/runs/1188102495

@simonw
Copy link
Owner Author

simonw commented Aug 31, 2021

It totally worked!

I downloaded the artifact and installed the application from the DMG (to /Applications/Datasette.app) - then I ran it and it told me I couldn't because it wasn't signed.

So I went to Security & Privacy in the system preferences and clicked "open it anyway"... and it launched and installed everything it needed into ~/.datasette-app/venv and the application worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant