No errors on empty schema, closes #64

simonw · Nov 21, 2020 · 69eaab1 · 69eaab1
1 parent 7e5b793
commit 69eaab1
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/datasette_graphql/utils.py b/datasette_graphql/utils.py
@@ -222,6 +222,11 @@ async def schema_for_database(datasette, database=None):
             )
         )
 
+    if not to_add:
+        # Empty schema throws a 500 error, so add something here
+        to_add.append(("empty", graphene.String()))
+        to_add.append(("resolve_empty", lambda a, b: "schema"))
+
     Query = type(
         "Query",
         (graphene.ObjectType,),

diff --git a/tests/test_graphql.py b/tests/test_graphql.py
@@ -714,6 +714,14 @@ async def test_permissions(db_path, db_path2, metadata, expected):
             assert response.status_code == expected_status
 
 
+@pytest.mark.asyncio
+async def test_no_error_on_empty_schema():
+    # https://github.com/simonw/datasette-graphql/issues/64
+    ds = Datasette([], memory=True)
+    response = await ds.client.get("/graphql", headers={"Accept": "text/html"})
+    assert response.status_code == 200
+
+
 @pytest.mark.asyncio
 async def test_table_action(db_path):
     ds = Datasette([db_path])