-
-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test against multiple SQLite versions #2352
Merged
Merged
Changes from 27 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
021c1aa
use sqlite-versions action for testing multiple versions
asg017 2998c44
Window functions?
asg017 a3275d0
deserialize needed in 3.11+?
asg017 2963fe2
more needed cflags
asg017 c5cbbb0
JSON clfag required before 3.38
asg017 ef3a02d
just test latest for now
asg017 33a7b4f
try some other version, continue-on-error: true tmp
asg017 c932a5a
continue-on-error wrong place
asg017 a1ba64d
narrowing down version bug
asg017 af37e62
latest sqlite version
asg017 86f8962
3.46
asg017 fd74b53
reduce sqlite versions
asg017 eb6b27d
debug LD_LIBRARY_PATH
asg017 8f0e7d8
new sqlite-versions
asg017 1c87e37
setup sqlite after?
asg017 a09bd61
bump sqlite-versions
asg017 cbbd58a
add 3.45
asg017 c514897
Workaround for #2353
simonw 5e653fd
named_parameters(sql) sync function, refs #2354
simonw db82a37
Merge branch 'main' into asg017/sqlite-versions-tests
simonw a8f17b6
separate workflow for python/sqlite support
asg017 2c4853f
rm any changes to test.yml
asg017 b3c70d9
bump sqlite-version
asg017 b6e57e5
bump sqlite-version
asg017 c15bdde
rm macos
asg017 941e583
rename workflow
asg017 ffe2ef7
rm unnecessar test
asg017 444d0a3
update name
asg017 ee5c377
skip flakey csv test
asg017 653c46d
black
asg017 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
name: Test | ||
|
||
on: [push, pull_request] | ||
|
||
permissions: | ||
contents: read | ||
|
||
jobs: | ||
test: | ||
runs-on: ${{ matrix.platform }} | ||
continue-on-error: true | ||
strategy: | ||
matrix: | ||
platform: [ubuntu-latest] | ||
python-version: [ "3.8", "3.9", "3.10", "3.11", "3.12"] | ||
sqlite-version: [ | ||
#"3", # latest version | ||
"3.46", | ||
#"3.45", | ||
#"3.27", | ||
#"3.26", | ||
"3.25", | ||
#"3.25.3", # 2018-09-25, window functions breaks test_upsert for some reason on 3.10, skip for now | ||
#"3.24", # 2018-06-04, added UPSERT support | ||
#"3.23.1" # 2018-04-10, before UPSERT | ||
] | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
allow-prereleases: true | ||
cache: pip | ||
cache-dependency-path: setup.py | ||
- name: Set up SQLite ${{ matrix.sqlite-version }} | ||
uses: asg017/sqlite-versions@71ea0de37ae739c33e447af91ba71dda8fcf22e6 | ||
with: | ||
version: ${{ matrix.sqlite-version }} | ||
cflags: "-DSQLITE_ENABLE_DESERIALIZE -DSQLITE_ENABLE_FTS5 -DSQLITE_ENABLE_FTS4 -DSQLITE_ENABLE_FTS3_PARENTHESIS -DSQLITE_ENABLE_RTREE -DSQLITE_ENABLE_JSON1" | ||
- run: python3 -c "import sqlite3; print(sqlite3.sqlite_version)" | ||
- run: echo $LD_LIBRARY_PATH | ||
- name: Build extension for --load-extension test | ||
run: |- | ||
(cd tests && gcc ext.c -fPIC -shared -o ext.so) | ||
- name: Install dependencies | ||
run: | | ||
pip install -e '.[test]' | ||
pip freeze | ||
- name: Run tests | ||
run: | | ||
pytest -n auto -m "not serial" | ||
pytest -m "serial" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change this to
Test SQLite versions
otherwise the GitHub Actions UI has a bunch of things all calledTest
: