Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default embed-model isn't really set? #317

Closed
Florents-Tselai opened this issue Oct 31, 2023 · 3 comments
Closed

Default embed-model isn't really set? #317

Florents-Tselai opened this issue Oct 31, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@Florents-Tselai
Copy link

Am I missing something in the following sequence or is this a bug where the default embed-model isn't really picked up, but works fine when it's provided explicitly?

$ llm embed-models default
sentence-transformers/all-MiniLM-L6-v2
$ llm embed -c "hello"
Error: You need to specify an embedding model (no default model is set)
$ llm embed -c "hello" -m sentence-transformers/all-MiniLM-L6-v2
[...OK...]
@simonw simonw added the bug Something isn't working label Nov 1, 2023
@simonw
Copy link
Owner

simonw commented Nov 1, 2023

Thanks, this looks like a bug.

I replicated myself like this:

$ llm embed-models default
ada-002
$ llm embed -c "hello"
Error: You need to specify an embedding model (no default model is set)

@Florents-Tselai
Copy link
Author

Yep, I just woke up & forked; I was about to check it out. Let me know if you'll be faster than me :) .

@simonw simonw closed this as completed in 8b78ac6 Nov 1, 2023
@simonw
Copy link
Owner

simonw commented Nov 1, 2023

Fixed!

simonw added a commit that referenced this issue Nov 1, 2023
simonw added a commit that referenced this issue Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants