Use readline for command-line editing in chats #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just importing the standard Python `readline` module allows editing with GNU readline keys. This is not explicitly documented in `click`, but is implied by their Changelog. On Windows, the `readline` module is not standard. This could be fixed by using `pyreadline3` in that case, but that should be a separate change. This change ignores the failure to load `readline` on Windows. The import ignores unused error from ruff, as that is by design - the `readline` module just needs importing to work. No specific unit tests, as `click` doesn't process mocks in a way that uses `readline`.
Open
|
@frabcus I've quickly reviewed the info about |
simonw
force-pushed
the
main
branch
2 times, most recently
from
569b316 to
f5a38d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just importing the standard Python
readlinemodule allows editing with GNU readline keys. This is not explicitly documented inclick, but is implied by their Changelog.On Windows, the
readlinemodule is not standard. This could be fixed by usingpyreadline3in that case, but that should be a separate change. This change ignores the failure to loadreadlineon Windows.The import ignores symbol unused error F401 from
ruff, as that is by design. Thereadlinemodule just needs importing to work.No specific unit tests, as
clickdoesn't process mocks in a way that usesreadline.