Fixed bug with sqlite-utils upsert --detect-types, closes #362

simonw · Jan 6, 2022 · a7b29bf · a7b29bf
1 parent 413f8ed
commit a7b29bf
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/sqlite_utils/cli.py b/sqlite_utils/cli.py
@@ -1045,6 +1045,7 @@ def upsert(
             not_null=not_null,
             default=default,
             encoding=encoding,
+            detect_types=detect_types,
             load_extension=load_extension,
             silent=silent,
         )

diff --git a/tests/test_cli.py b/tests/test_cli.py
@@ -1974,6 +1974,24 @@ def _test():
         _test()
 
 
+@pytest.mark.parametrize("option", ("-d", "--detect-types"))
+def test_upsert_detect_types(tmpdir, option):
+    db_path = str(tmpdir / "test.db")
+    data = "id,name,age,weight\n1,Cleo,6,45.5\n2,Dori,1,3.5"
+    result = CliRunner().invoke(
+        cli.cli,
+        ["upsert", db_path, "creatures", "-", "--csv", "--pk", "id"] + [option],
+        catch_exceptions=False,
+        input=data,
+    )
+    assert result.exit_code == 0
+    db = Database(db_path)
+    assert list(db["creatures"].rows) == [
+        {"id": 1, "name": "Cleo", "age": 6, "weight": 45.5},
+        {"id": 2, "name": "Dori", "age": 1, "weight": 3.5},
+    ]
+
+
 @pytest.mark.parametrize(
     "input,expected",
     (