-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1.1.0 #3
Open
Grochocinski
wants to merge
41
commits into
main
Choose a base branch
from
numpy_rewrite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
V1.1.0 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… function, inlined some statements for efficiency
Speed Up Testing Results (TLDR ~30% Improvement)
sample size of 10 runs each, executed in randomized order |
…es, minor refactoring
…adthedocs build functional
…y into helper methdos
Alright, I think it's actually good to go at this point (passes all tests / Ruff formatting/linting checks / type checks, as well as showing substantial performance uplift and having easy-to-read code) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR overhauls the
mrg32k3a
random number generator to significantly improve performance, reduce redundancy, and modernize the internal structure. Highlights:Key Changes
mrg32k3a
A[1|2]p[47|94|141]
) and constants (mrgm1_plus_1
, etc.) to eliminate redundant computationnp.ndarray
for efficient slicing and modular matrix math, whileseed()
still accepts a Pythontuple
_advance_state()
and_apply_transition()
helpersTesting
Performance Summary
random()
)start_*
)reset_*
)(See note below)
S_SS_SSS
Summary
This refactor delivers a leaner, faster, and more maintainable implementation of
mrg32k3a
, with significant speedups in all key random variate generation paths and much broader test coverage. Ready for review and merge.